Skip to content

ref(core): Set span status internal_error instead of unknown_error #17909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

ref(core): Set span status internal_error instead of unknown_error #17909

wants to merge 5 commits into from
+41 −41

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Oct 10, 2025 •
edited
Loading

This PR refactors almost all occurances of our SDK setting a span status of unknown_error to setting internal_error instead. #17814 explains why we do this.

I left a few selected occurances of unknown_error where I think it's fine to not change them. Worth noting, Relay already converts unknown_error to internal_error, so this is rather a "cleanup" and only has impact on self-hosted Sentry versions for now.

closes #17814

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 10, 2025 •
edited
Loading

size-limit report 📦

Path Size % Change Change
@sentry/browser 24.65 kB +0.01% +2 B 🔺
@sentry/browser - with treeshaking flags 23.14 kB +0.01% +2 B 🔺
@sentry/browser (incl. Tracing) 40.99 kB -0.01% -1 B 🔽
@sentry/browser (incl. Tracing, Replay) 79.29 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 68.97 kB -0.01% -1 B 🔽
@sentry/browser (incl. Tracing, Replay with Canvas) 84 kB -0.01% -1 B 🔽
@sentry/browser (incl. Tracing, Replay, Feedback) 96.16 kB -0.01% -1 B 🔽
@sentry/browser (incl. Feedback) 41.33 kB +0.01% +3 B 🔺
@sentry/browser (incl. sendFeedback) 29.3 kB +0.02% +3 B 🔺
@sentry/browser (incl. FeedbackAsync) 34.26 kB +0.01% +2 B 🔺
@sentry/react 26.35 kB +0.01% +2 B 🔺
@sentry/react (incl. Tracing) 42.99 kB +0.01% +4 B 🔺
@sentry/vue 29.14 kB +0.01% +2 B 🔺
@sentry/vue (incl. Tracing) 42.79 kB - -
@sentry/svelte 24.66 kB +0.02% +3 B 🔺
CDN Bundle 26.94 kB -0.01% -1 B 🔽
CDN Bundle (incl. Tracing) 41.65 kB +0.01% +1 B 🔺
CDN Bundle (incl. Tracing, Replay) 77.89 kB -0.01% -1 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) 83.35 kB -0.01% -1 B 🔽
CDN Bundle - uncompressed 78.95 kB +0.01% +1 B 🔺
CDN Bundle (incl. Tracing) - uncompressed 123.53 kB +0.01% +2 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed 238.54 kB +0.01% +2 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 251.31 kB +0.01% +2 B 🔺
@sentry/nextjs (client) 45.05 kB -0.01% -1 B 🔽
@sentry/sveltekit (client) 41.41 kB -0.01% -1 B 🔽
@sentry/node-core 50.78 kB -0.01% -1 B 🔽
@sentry/node 154.41 kB +0.01% +11 B 🔺
@sentry/node - without tracing 92.66 kB +0.01% +4 B 🔺
@sentry/aws-serverless 106.36 kB +0.01% +10 B 🔺

View base workflow run

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 10, 2025 •
edited
Loading

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 9,047 - 9,344 -3%
GET With Sentry 1,381 15% 1,412 -2%
GET With Sentry (error only) 6,014 66% 6,130 -2%
POST Baseline 1,203 - 1,211 -1%
POST With Sentry 495 41% 509 -3%
POST With Sentry (error only) 1,044 87% 1,069 -2%
MYSQL Baseline 3,269 - 3,221 +1%
MYSQL With Sentry 473 14% 370 +28%
MYSQL With Sentry (error only) 2,639 81% 2,625 +1%

View base workflow run

@Lms24 Lms24 force-pushed the lms/ref-core-span-status-internal-error branch from 3f632a7 to dcd9c05 Compare October 16, 2025 09:15
@Lms24 Lms24 self-assigned this Oct 16, 2025
@Lms24 Lms24 force-pushed the lms/ref-core-span-status-internal-error branch from dcd9c05 to 943783c Compare October 16, 2025 12:05
@Lms24 Lms24 marked this pull request as ready for review October 16, 2025 14:10
@Lms24 Lms24 requested review from a team, RulaKhaled, obostjancic, s1gr1d and stephanie-anderson and removed request for a team and stephanie-anderson October 16, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@obostjancic obostjancic Awaiting requested review from obostjancic

@s1gr1d s1gr1d Awaiting requested review from s1gr1d s1gr1d was automatically assigned from getsentry/team-web-sdk-frontend

@RulaKhaled RulaKhaled Awaiting requested review from RulaKhaled

At least 1 approving review is required to merge this pull request.

Assignees

@Lms24 Lms24

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Default to internal_error rather than unknown_error when setting error span status

1 participant

@Lms24